difflayer.go 20 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533
  1. // Copyright 2019 The go-ethereum Authors
  2. // This file is part of the go-ethereum library.
  3. //
  4. // The go-ethereum library is free software: you can redistribute it and/or modify
  5. // it under the terms of the GNU Lesser General Public License as published by
  6. // the Free Software Foundation, either version 3 of the License, or
  7. // (at your option) any later version.
  8. //
  9. // The go-ethereum library is distributed in the hope that it will be useful,
  10. // but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. // GNU Lesser General Public License for more details.
  13. //
  14. // You should have received a copy of the GNU Lesser General Public License
  15. // along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
  16. package snapshot
  17. import (
  18. "encoding/binary"
  19. "fmt"
  20. "math"
  21. "math/rand"
  22. "sort"
  23. "sync"
  24. "sync/atomic"
  25. "time"
  26. "github.com/ethereum/go-ethereum/common"
  27. "github.com/ethereum/go-ethereum/rlp"
  28. "github.com/steakknife/bloomfilter"
  29. )
  30. var (
  31. // aggregatorMemoryLimit is the maximum size of the bottom-most diff layer
  32. // that aggregates the writes from above until it's flushed into the disk
  33. // layer.
  34. //
  35. // Note, bumping this up might drastically increase the size of the bloom
  36. // filters that's stored in every diff layer. Don't do that without fully
  37. // understanding all the implications.
  38. aggregatorMemoryLimit = uint64(4 * 1024 * 1024)
  39. // aggregatorItemLimit is an approximate number of items that will end up
  40. // in the agregator layer before it's flushed out to disk. A plain account
  41. // weighs around 14B (+hash), a storage slot 32B (+hash), a deleted slot
  42. // 0B (+hash). Slots are mostly set/unset in lockstep, so thet average at
  43. // 16B (+hash). All in all, the average entry seems to be 15+32=47B. Use a
  44. // smaller number to be on the safe side.
  45. aggregatorItemLimit = aggregatorMemoryLimit / 42
  46. // bloomTargetError is the target false positive rate when the aggregator
  47. // layer is at its fullest. The actual value will probably move around up
  48. // and down from this number, it's mostly a ballpark figure.
  49. //
  50. // Note, dropping this down might drastically increase the size of the bloom
  51. // filters that's stored in every diff layer. Don't do that without fully
  52. // understanding all the implications.
  53. bloomTargetError = 0.02
  54. // bloomSize is the ideal bloom filter size given the maximum number of items
  55. // it's expected to hold and the target false positive error rate.
  56. bloomSize = math.Ceil(float64(aggregatorItemLimit) * math.Log(bloomTargetError) / math.Log(1/math.Pow(2, math.Log(2))))
  57. // bloomFuncs is the ideal number of bits a single entry should set in the
  58. // bloom filter to keep its size to a minimum (given it's size and maximum
  59. // entry count).
  60. bloomFuncs = math.Round((bloomSize / float64(aggregatorItemLimit)) * math.Log(2))
  61. // the bloom offsets are runtime constants which determines which part of the
  62. // the account/storage hash the hasher functions looks at, to determine the
  63. // bloom key for an account/slot. This is randomized at init(), so that the
  64. // global population of nodes do not all display the exact same behaviour with
  65. // regards to bloom content
  66. bloomDestructHasherOffset = 0
  67. bloomAccountHasherOffset = 0
  68. bloomStorageHasherOffset = 0
  69. )
  70. func init() {
  71. // Init the bloom offsets in the range [0:24] (requires 8 bytes)
  72. bloomDestructHasherOffset = rand.Intn(25)
  73. bloomAccountHasherOffset = rand.Intn(25)
  74. bloomStorageHasherOffset = rand.Intn(25)
  75. // The destruct and account blooms must be different, as the storage slots
  76. // will check for destruction too for every bloom miss. It should not collide
  77. // with modified accounts.
  78. for bloomAccountHasherOffset == bloomDestructHasherOffset {
  79. bloomAccountHasherOffset = rand.Intn(25)
  80. }
  81. }
  82. // diffLayer represents a collection of modifications made to a state snapshot
  83. // after running a block on top. It contains one sorted list for the account trie
  84. // and one-one list for each storage tries.
  85. //
  86. // The goal of a diff layer is to act as a journal, tracking recent modifications
  87. // made to the state, that have not yet graduated into a semi-immutable state.
  88. type diffLayer struct {
  89. origin *diskLayer // Base disk layer to directly use on bloom misses
  90. parent snapshot // Parent snapshot modified by this one, never nil
  91. memory uint64 // Approximate guess as to how much memory we use
  92. root common.Hash // Root hash to which this snapshot diff belongs to
  93. stale uint32 // Signals that the layer became stale (state progressed)
  94. destructSet map[common.Hash]struct{} // Keyed markers for deleted (and potentially) recreated accounts
  95. accountList []common.Hash // List of account for iteration. If it exists, it's sorted, otherwise it's nil
  96. accountData map[common.Hash][]byte // Keyed accounts for direct retrival (nil means deleted)
  97. storageList map[common.Hash][]common.Hash // List of storage slots for iterated retrievals, one per account. Any existing lists are sorted if non-nil
  98. storageData map[common.Hash]map[common.Hash][]byte // Keyed storage slots for direct retrival. one per account (nil means deleted)
  99. diffed *bloomfilter.Filter // Bloom filter tracking all the diffed items up to the disk layer
  100. lock sync.RWMutex
  101. }
  102. // destructBloomHasher is a wrapper around a common.Hash to satisfy the interface
  103. // API requirements of the bloom library used. It's used to convert a destruct
  104. // event into a 64 bit mini hash.
  105. type destructBloomHasher common.Hash
  106. func (h destructBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
  107. func (h destructBloomHasher) Sum(b []byte) []byte { panic("not implemented") }
  108. func (h destructBloomHasher) Reset() { panic("not implemented") }
  109. func (h destructBloomHasher) BlockSize() int { panic("not implemented") }
  110. func (h destructBloomHasher) Size() int { return 8 }
  111. func (h destructBloomHasher) Sum64() uint64 {
  112. return binary.BigEndian.Uint64(h[bloomDestructHasherOffset : bloomDestructHasherOffset+8])
  113. }
  114. // accountBloomHasher is a wrapper around a common.Hash to satisfy the interface
  115. // API requirements of the bloom library used. It's used to convert an account
  116. // hash into a 64 bit mini hash.
  117. type accountBloomHasher common.Hash
  118. func (h accountBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
  119. func (h accountBloomHasher) Sum(b []byte) []byte { panic("not implemented") }
  120. func (h accountBloomHasher) Reset() { panic("not implemented") }
  121. func (h accountBloomHasher) BlockSize() int { panic("not implemented") }
  122. func (h accountBloomHasher) Size() int { return 8 }
  123. func (h accountBloomHasher) Sum64() uint64 {
  124. return binary.BigEndian.Uint64(h[bloomAccountHasherOffset : bloomAccountHasherOffset+8])
  125. }
  126. // storageBloomHasher is a wrapper around a [2]common.Hash to satisfy the interface
  127. // API requirements of the bloom library used. It's used to convert an account
  128. // hash into a 64 bit mini hash.
  129. type storageBloomHasher [2]common.Hash
  130. func (h storageBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
  131. func (h storageBloomHasher) Sum(b []byte) []byte { panic("not implemented") }
  132. func (h storageBloomHasher) Reset() { panic("not implemented") }
  133. func (h storageBloomHasher) BlockSize() int { panic("not implemented") }
  134. func (h storageBloomHasher) Size() int { return 8 }
  135. func (h storageBloomHasher) Sum64() uint64 {
  136. return binary.BigEndian.Uint64(h[0][bloomStorageHasherOffset:bloomStorageHasherOffset+8]) ^
  137. binary.BigEndian.Uint64(h[1][bloomStorageHasherOffset:bloomStorageHasherOffset+8])
  138. }
  139. // newDiffLayer creates a new diff on top of an existing snapshot, whether that's a low
  140. // level persistent database or a hierarchical diff already.
  141. func newDiffLayer(parent snapshot, root common.Hash, destructs map[common.Hash]struct{}, accounts map[common.Hash][]byte, storage map[common.Hash]map[common.Hash][]byte) *diffLayer {
  142. // Create the new layer with some pre-allocated data segments
  143. dl := &diffLayer{
  144. parent: parent,
  145. root: root,
  146. destructSet: destructs,
  147. accountData: accounts,
  148. storageData: storage,
  149. }
  150. switch parent := parent.(type) {
  151. case *diskLayer:
  152. dl.rebloom(parent)
  153. case *diffLayer:
  154. dl.rebloom(parent.origin)
  155. default:
  156. panic("unknown parent type")
  157. }
  158. // Sanity check that accounts or storage slots are never nil
  159. for accountHash, blob := range accounts {
  160. if blob == nil {
  161. panic(fmt.Sprintf("account %#x nil", accountHash))
  162. }
  163. }
  164. for accountHash, slots := range storage {
  165. if slots == nil {
  166. panic(fmt.Sprintf("storage %#x nil", accountHash))
  167. }
  168. }
  169. // Determine memory size and track the dirty writes
  170. for _, data := range accounts {
  171. dl.memory += uint64(common.HashLength + len(data))
  172. snapshotDirtyAccountWriteMeter.Mark(int64(len(data)))
  173. }
  174. // Fill the storage hashes and sort them for the iterator
  175. dl.storageList = make(map[common.Hash][]common.Hash)
  176. for accountHash := range destructs {
  177. dl.storageList[accountHash] = nil
  178. }
  179. // Determine memory size and track the dirty writes
  180. for _, slots := range storage {
  181. for _, data := range slots {
  182. dl.memory += uint64(common.HashLength + len(data))
  183. snapshotDirtyStorageWriteMeter.Mark(int64(len(data)))
  184. }
  185. }
  186. dl.memory += uint64(len(dl.storageList) * common.HashLength)
  187. return dl
  188. }
  189. // rebloom discards the layer's current bloom and rebuilds it from scratch based
  190. // on the parent's and the local diffs.
  191. func (dl *diffLayer) rebloom(origin *diskLayer) {
  192. dl.lock.Lock()
  193. defer dl.lock.Unlock()
  194. defer func(start time.Time) {
  195. snapshotBloomIndexTimer.Update(time.Since(start))
  196. }(time.Now())
  197. // Inject the new origin that triggered the rebloom
  198. dl.origin = origin
  199. // Retrieve the parent bloom or create a fresh empty one
  200. if parent, ok := dl.parent.(*diffLayer); ok {
  201. parent.lock.RLock()
  202. dl.diffed, _ = parent.diffed.Copy()
  203. parent.lock.RUnlock()
  204. } else {
  205. dl.diffed, _ = bloomfilter.New(uint64(bloomSize), uint64(bloomFuncs))
  206. }
  207. // Iterate over all the accounts and storage slots and index them
  208. for hash := range dl.destructSet {
  209. dl.diffed.Add(destructBloomHasher(hash))
  210. }
  211. for hash := range dl.accountData {
  212. dl.diffed.Add(accountBloomHasher(hash))
  213. }
  214. for accountHash, slots := range dl.storageData {
  215. for storageHash := range slots {
  216. dl.diffed.Add(storageBloomHasher{accountHash, storageHash})
  217. }
  218. }
  219. // Calculate the current false positive rate and update the error rate meter.
  220. // This is a bit cheating because subsequent layers will overwrite it, but it
  221. // should be fine, we're only interested in ballpark figures.
  222. k := float64(dl.diffed.K())
  223. n := float64(dl.diffed.N())
  224. m := float64(dl.diffed.M())
  225. snapshotBloomErrorGauge.Update(math.Pow(1.0-math.Exp((-k)*(n+0.5)/(m-1)), k))
  226. }
  227. // Root returns the root hash for which this snapshot was made.
  228. func (dl *diffLayer) Root() common.Hash {
  229. return dl.root
  230. }
  231. // Parent returns the subsequent layer of a diff layer.
  232. func (dl *diffLayer) Parent() snapshot {
  233. return dl.parent
  234. }
  235. // Stale return whether this layer has become stale (was flattened across) or if
  236. // it's still live.
  237. func (dl *diffLayer) Stale() bool {
  238. return atomic.LoadUint32(&dl.stale) != 0
  239. }
  240. // Account directly retrieves the account associated with a particular hash in
  241. // the snapshot slim data format.
  242. func (dl *diffLayer) Account(hash common.Hash) (*Account, error) {
  243. data, err := dl.AccountRLP(hash)
  244. if err != nil {
  245. return nil, err
  246. }
  247. if len(data) == 0 { // can be both nil and []byte{}
  248. return nil, nil
  249. }
  250. account := new(Account)
  251. if err := rlp.DecodeBytes(data, account); err != nil {
  252. panic(err)
  253. }
  254. return account, nil
  255. }
  256. // AccountRLP directly retrieves the account RLP associated with a particular
  257. // hash in the snapshot slim data format.
  258. func (dl *diffLayer) AccountRLP(hash common.Hash) ([]byte, error) {
  259. // Check the bloom filter first whether there's even a point in reaching into
  260. // all the maps in all the layers below
  261. dl.lock.RLock()
  262. hit := dl.diffed.Contains(accountBloomHasher(hash))
  263. if !hit {
  264. hit = dl.diffed.Contains(destructBloomHasher(hash))
  265. }
  266. dl.lock.RUnlock()
  267. // If the bloom filter misses, don't even bother with traversing the memory
  268. // diff layers, reach straight into the bottom persistent disk layer
  269. if !hit {
  270. snapshotBloomAccountMissMeter.Mark(1)
  271. return dl.origin.AccountRLP(hash)
  272. }
  273. // The bloom filter hit, start poking in the internal maps
  274. return dl.accountRLP(hash, 0)
  275. }
  276. // accountRLP is an internal version of AccountRLP that skips the bloom filter
  277. // checks and uses the internal maps to try and retrieve the data. It's meant
  278. // to be used if a higher layer's bloom filter hit already.
  279. func (dl *diffLayer) accountRLP(hash common.Hash, depth int) ([]byte, error) {
  280. dl.lock.RLock()
  281. defer dl.lock.RUnlock()
  282. // If the layer was flattened into, consider it invalid (any live reference to
  283. // the original should be marked as unusable).
  284. if dl.Stale() {
  285. return nil, ErrSnapshotStale
  286. }
  287. // If the account is known locally, return it
  288. if data, ok := dl.accountData[hash]; ok {
  289. snapshotDirtyAccountHitMeter.Mark(1)
  290. snapshotDirtyAccountHitDepthHist.Update(int64(depth))
  291. snapshotDirtyAccountReadMeter.Mark(int64(len(data)))
  292. snapshotBloomAccountTrueHitMeter.Mark(1)
  293. return data, nil
  294. }
  295. // If the account is known locally, but deleted, return it
  296. if _, ok := dl.destructSet[hash]; ok {
  297. snapshotDirtyAccountHitMeter.Mark(1)
  298. snapshotDirtyAccountHitDepthHist.Update(int64(depth))
  299. snapshotDirtyAccountInexMeter.Mark(1)
  300. snapshotBloomAccountTrueHitMeter.Mark(1)
  301. return nil, nil
  302. }
  303. // Account unknown to this diff, resolve from parent
  304. if diff, ok := dl.parent.(*diffLayer); ok {
  305. return diff.accountRLP(hash, depth+1)
  306. }
  307. // Failed to resolve through diff layers, mark a bloom error and use the disk
  308. snapshotBloomAccountFalseHitMeter.Mark(1)
  309. return dl.parent.AccountRLP(hash)
  310. }
  311. // Storage directly retrieves the storage data associated with a particular hash,
  312. // within a particular account. If the slot is unknown to this diff, it's parent
  313. // is consulted.
  314. func (dl *diffLayer) Storage(accountHash, storageHash common.Hash) ([]byte, error) {
  315. // Check the bloom filter first whether there's even a point in reaching into
  316. // all the maps in all the layers below
  317. dl.lock.RLock()
  318. hit := dl.diffed.Contains(storageBloomHasher{accountHash, storageHash})
  319. if !hit {
  320. hit = dl.diffed.Contains(destructBloomHasher(accountHash))
  321. }
  322. dl.lock.RUnlock()
  323. // If the bloom filter misses, don't even bother with traversing the memory
  324. // diff layers, reach straight into the bottom persistent disk layer
  325. if !hit {
  326. snapshotBloomStorageMissMeter.Mark(1)
  327. return dl.origin.Storage(accountHash, storageHash)
  328. }
  329. // The bloom filter hit, start poking in the internal maps
  330. return dl.storage(accountHash, storageHash, 0)
  331. }
  332. // storage is an internal version of Storage that skips the bloom filter checks
  333. // and uses the internal maps to try and retrieve the data. It's meant to be
  334. // used if a higher layer's bloom filter hit already.
  335. func (dl *diffLayer) storage(accountHash, storageHash common.Hash, depth int) ([]byte, error) {
  336. dl.lock.RLock()
  337. defer dl.lock.RUnlock()
  338. // If the layer was flattened into, consider it invalid (any live reference to
  339. // the original should be marked as unusable).
  340. if dl.Stale() {
  341. return nil, ErrSnapshotStale
  342. }
  343. // If the account is known locally, try to resolve the slot locally
  344. if storage, ok := dl.storageData[accountHash]; ok {
  345. if data, ok := storage[storageHash]; ok {
  346. snapshotDirtyStorageHitMeter.Mark(1)
  347. snapshotDirtyStorageHitDepthHist.Update(int64(depth))
  348. if n := len(data); n > 0 {
  349. snapshotDirtyStorageReadMeter.Mark(int64(n))
  350. } else {
  351. snapshotDirtyStorageInexMeter.Mark(1)
  352. }
  353. snapshotBloomStorageTrueHitMeter.Mark(1)
  354. return data, nil
  355. }
  356. }
  357. // If the account is known locally, but deleted, return an empty slot
  358. if _, ok := dl.destructSet[accountHash]; ok {
  359. snapshotDirtyStorageHitMeter.Mark(1)
  360. snapshotDirtyStorageHitDepthHist.Update(int64(depth))
  361. snapshotDirtyStorageInexMeter.Mark(1)
  362. snapshotBloomStorageTrueHitMeter.Mark(1)
  363. return nil, nil
  364. }
  365. // Storage slot unknown to this diff, resolve from parent
  366. if diff, ok := dl.parent.(*diffLayer); ok {
  367. return diff.storage(accountHash, storageHash, depth+1)
  368. }
  369. // Failed to resolve through diff layers, mark a bloom error and use the disk
  370. snapshotBloomStorageFalseHitMeter.Mark(1)
  371. return dl.parent.Storage(accountHash, storageHash)
  372. }
  373. // Update creates a new layer on top of the existing snapshot diff tree with
  374. // the specified data items.
  375. func (dl *diffLayer) Update(blockRoot common.Hash, destructs map[common.Hash]struct{}, accounts map[common.Hash][]byte, storage map[common.Hash]map[common.Hash][]byte) *diffLayer {
  376. return newDiffLayer(dl, blockRoot, destructs, accounts, storage)
  377. }
  378. // flatten pushes all data from this point downwards, flattening everything into
  379. // a single diff at the bottom. Since usually the lowermost diff is the largest,
  380. // the flattening bulds up from there in reverse.
  381. func (dl *diffLayer) flatten() snapshot {
  382. // If the parent is not diff, we're the first in line, return unmodified
  383. parent, ok := dl.parent.(*diffLayer)
  384. if !ok {
  385. return dl
  386. }
  387. // Parent is a diff, flatten it first (note, apart from weird corned cases,
  388. // flatten will realistically only ever merge 1 layer, so there's no need to
  389. // be smarter about grouping flattens together).
  390. parent = parent.flatten().(*diffLayer)
  391. parent.lock.Lock()
  392. defer parent.lock.Unlock()
  393. // Before actually writing all our data to the parent, first ensure that the
  394. // parent hasn't been 'corrupted' by someone else already flattening into it
  395. if atomic.SwapUint32(&parent.stale, 1) != 0 {
  396. panic("parent diff layer is stale") // we've flattened into the same parent from two children, boo
  397. }
  398. // Overwrite all the updated accounts blindly, merge the sorted list
  399. for hash := range dl.destructSet {
  400. parent.destructSet[hash] = struct{}{}
  401. delete(parent.accountData, hash)
  402. delete(parent.storageData, hash)
  403. }
  404. for hash, data := range dl.accountData {
  405. parent.accountData[hash] = data
  406. }
  407. // Overwrite all the updated storage slots (individually)
  408. for accountHash, storage := range dl.storageData {
  409. // If storage didn't exist (or was deleted) in the parent, overwrite blindly
  410. if _, ok := parent.storageData[accountHash]; !ok {
  411. parent.storageData[accountHash] = storage
  412. continue
  413. }
  414. // Storage exists in both parent and child, merge the slots
  415. comboData := parent.storageData[accountHash]
  416. for storageHash, data := range storage {
  417. comboData[storageHash] = data
  418. }
  419. parent.storageData[accountHash] = comboData
  420. }
  421. // Return the combo parent
  422. return &diffLayer{
  423. parent: parent.parent,
  424. origin: parent.origin,
  425. root: dl.root,
  426. destructSet: parent.destructSet,
  427. accountData: parent.accountData,
  428. storageData: parent.storageData,
  429. storageList: make(map[common.Hash][]common.Hash),
  430. diffed: dl.diffed,
  431. memory: parent.memory + dl.memory,
  432. }
  433. }
  434. // AccountList returns a sorted list of all accounts in this difflayer, including
  435. // the deleted ones.
  436. //
  437. // Note, the returned slice is not a copy, so do not modify it.
  438. func (dl *diffLayer) AccountList() []common.Hash {
  439. // If an old list already exists, return it
  440. dl.lock.RLock()
  441. list := dl.accountList
  442. dl.lock.RUnlock()
  443. if list != nil {
  444. return list
  445. }
  446. // No old sorted account list exists, generate a new one
  447. dl.lock.Lock()
  448. defer dl.lock.Unlock()
  449. dl.accountList = make([]common.Hash, 0, len(dl.destructSet)+len(dl.accountData))
  450. for hash := range dl.accountData {
  451. dl.accountList = append(dl.accountList, hash)
  452. }
  453. for hash := range dl.destructSet {
  454. if _, ok := dl.accountData[hash]; !ok {
  455. dl.accountList = append(dl.accountList, hash)
  456. }
  457. }
  458. sort.Sort(hashes(dl.accountList))
  459. return dl.accountList
  460. }
  461. // StorageList returns a sorted list of all storage slot hashes in this difflayer
  462. // for the given account.
  463. //
  464. // Note, the returned slice is not a copy, so do not modify it.
  465. func (dl *diffLayer) StorageList(accountHash common.Hash) []common.Hash {
  466. // If an old list already exists, return it
  467. dl.lock.RLock()
  468. list := dl.storageList[accountHash]
  469. dl.lock.RUnlock()
  470. if list != nil {
  471. return list
  472. }
  473. // No old sorted account list exists, generate a new one
  474. dl.lock.Lock()
  475. defer dl.lock.Unlock()
  476. storageMap := dl.storageData[accountHash]
  477. storageList := make([]common.Hash, 0, len(storageMap))
  478. for k := range storageMap {
  479. storageList = append(storageList, k)
  480. }
  481. sort.Sort(hashes(storageList))
  482. dl.storageList[accountHash] = storageList
  483. return storageList
  484. }