Browse Source

Return null coinbase when accounts not created

Was previously returning nonsensical “0x”
Taylor Gerring 10 years ago
parent
commit
f49e17eb39
1 changed files with 7 additions and 1 deletions
  1. 7 1
      rpc/api.go

+ 7 - 1
rpc/api.go

@@ -490,7 +490,13 @@ func (p *EthereumApi) GetRequestReply(req *RpcRequest, reply *interface{}) error
 	case "net_peerCount":
 		*reply = toHex(big.NewInt(int64(p.xeth().PeerCount())).Bytes())
 	case "eth_coinbase":
-		*reply = p.xeth().Coinbase()
+		// TODO handling of empty coinbase due to lack of accounts
+		res := p.xeth().Coinbase()
+		if res == "0x" || res == "0x0" {
+			*reply = nil
+		} else {
+			*reply = res
+		}
 	case "eth_mining":
 		*reply = p.xeth().IsMining()
 	case "eth_gasPrice":