瀏覽代碼

Improve error string and remove unneeded else clause

Gustav Simonsson 10 年之前
父節點
當前提交
d9addf79fa
共有 3 個文件被更改,包括 6 次插入7 次删除
  1. 1 2
      miner/remote_agent.go
  2. 1 1
      rpc/api/eth.go
  3. 4 4
      rpc/shared/errors.go

+ 1 - 2
miner/remote_agent.go

@@ -112,9 +112,8 @@ func (a *RemoteAgent) GetWork() ([3]string, error) {
 
 		a.work[block.HashNoNonce()] = a.currentWork
 		return res, nil
-	} else {
-		return res, errors.New("No work available yet, don't panic.")
 	}
+	return res, errors.New("No work available yet, don't panic.")
 }
 
 // Returns true or false, but does not indicate if the PoW was correct

+ 1 - 1
rpc/api/eth.go

@@ -565,7 +565,7 @@ func (self *ethApi) GetWork(req *shared.Request) (interface{}, error) {
 	self.xeth.SetMining(true, 0)
 	ret, err := self.xeth.RemoteMining().GetWork()
 	if err != nil {
-		return nil, shared.NewNotReadyError("getWork")
+		return nil, shared.NewNotReadyError("mining work")
 	} else {
 		return ret, nil
 	}

+ 4 - 4
rpc/shared/errors.go

@@ -65,16 +65,16 @@ func NewNotImplementedError(method string) *NotImplementedError {
 }
 
 type NotReadyError struct {
-	Method string
+	Resource string
 }
 
 func (e *NotReadyError) Error() string {
-	return fmt.Sprintf("%s method not ready", e.Method)
+	return fmt.Sprintf("%s not ready", e.Resource)
 }
 
-func NewNotReadyError(method string) *NotReadyError {
+func NewNotReadyError(resource string) *NotReadyError {
 	return &NotReadyError{
-		Method: method,
+		Resource: resource,
 	}
 }