Browse Source

node: prefer nil slices over zero-length slices (#19083)

Matthew Halpern 6 years ago
parent
commit
7b3e3d549e
2 changed files with 2 additions and 2 deletions
  1. 1 1
      node/config.go
  2. 1 1
      node/node.go

+ 1 - 1
node/config.go

@@ -466,7 +466,7 @@ func makeAccountManager(conf *Config) (*accounts.Manager, string, error) {
 		return nil, "", err
 		return nil, "", err
 	}
 	}
 	// Assemble the account manager and supported backends
 	// Assemble the account manager and supported backends
-	backends := []accounts.Backend{}
+	var backends []accounts.Backend
 	if len(conf.ExternalSigner) > 0 {
 	if len(conf.ExternalSigner) > 0 {
 		log.Info("Using external signer", "url", conf.ExternalSigner)
 		log.Info("Using external signer", "url", conf.ExternalSigner)
 		if extapi, err := external.NewExternalBackend(conf.ExternalSigner); err == nil {
 		if extapi, err := external.NewExternalBackend(conf.ExternalSigner); err == nil {

+ 1 - 1
node/node.go

@@ -220,7 +220,7 @@ func (n *Node) Start() error {
 		return convertFileLockError(err)
 		return convertFileLockError(err)
 	}
 	}
 	// Start each of the services
 	// Start each of the services
-	started := []reflect.Type{}
+	var started []reflect.Type
 	for kind, service := range services {
 	for kind, service := range services {
 		// Start the next service, stopping all previous upon failure
 		// Start the next service, stopping all previous upon failure
 		if err := service.Start(running); err != nil {
 		if err := service.Start(running); err != nil {